Skip to content

fix: library search boosting #1866

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 10, 2023
Merged

fix: library search boosting #1866

merged 1 commit into from
Feb 10, 2023

Conversation

kittaakos
Copy link
Contributor

@kittaakos kittaakos commented Feb 7, 2023 •
edited
Loading

Motivation

IDE2 modifies the lib/core search items from the CLI. This PR fixes it so that when you search for SD, you will get SD as the first hit.

Change description

I moved the search boosting to the IDE2 backend.

Lib search order

  • 'Arduino' in types,
  • others
  • 'Arduino' and 'Retired' in types
  • 'Retired' in types (note there is no such lib currently)

Core search order

  • 'Arduino' in types,
  • others
  • 'Arduino' in types and deprecated is true.
  • deprecated is true (note there is no such core currently)

Other information

Closes #1106

Reviewer checklist

  • PR addresses a single concern.
  • The PR has no duplicates (please search among the Pull Requests before creating one)
  • PR title and description are properly filled.
  • Docs have been added / updated (for bug fixes / features)

fix: library search boosting
7a7078a 
Closes #1106

Signed-off-by: Akos Kitta <a.kitta@arduino.cc>
@per1234 per1234 added topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project labels Feb 7, 2023
per1234
per1234 approved these changes Feb 9, 2023
View reviewed changes
Copy link
Contributor

@per1234 per1234 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Akos!

@kittaakos kittaakos merged commit 79b6b7e into main Feb 10, 2023
@kittaakos kittaakos deleted the #1106 branch February 10, 2023 13:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@per1234 per1234 per1234 approved these changes

@AlbyIanna AlbyIanna Awaiting requested review from AlbyIanna

Assignees
No one assigned
Labels
topic: code Related to content of the project itself type: imperfection Perceived defect in any part of project
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sort Library Manager list by relevance
2 participants
@kittaakos @per1234